[Kde-pim] Review Request 114241: Don't do redundant flag changes in setItemsFlags

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114241/#review44977
-----------------------------------------------------------

Ship it!


Perfect! Thanks a lot for the fix.

Do you have commit access, or should I push it for you?

- Dan Vrátil


On Dec. 1, 2013, 8:31 p.m., Tomáš Trnka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114241/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2013, 8:31 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> DataStore::setItemsFlags doesn't work correctly when some of the
> flags were already set. See https://bugs.kde.org/328286 for a 
> complete description of the problem.
> 
> Instead of removing all flags and then adding the requested ones
> back, figure out which flags are actually getting added or removed
> and only apply those changes.
> 
> Everything is still carried out in up to two DB queries.
> 
> Additionally, don't send out the change notification if nothing
> has actually changed.
> 
> BUG:328286
> 
> 
> Diffs
> -----
> 
>   server/src/storage/datastore.cpp d8dd0bffed8a7be89e0f87f30b5fcd155274a22d 
> 
> Diff: http://git.reviewboard.kde.org/r/114241/diff/
> 
> 
> Testing
> -------
> 
> All unit tests pass.
> Everything seems to work fine during ordinary usage of three IMAP resources.
> 
> 
> Thanks,
> 
> Tomáš Trnka
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/