[Kde-pim] Review Request 112104: coding style for login.cpp

[Guy Maurel]

> On Aug. 15, 2013, 6:18 p.m., Kevin Krammer wrote:
> > server/src/handler/login.cpp, line 46
> > <http://git.reviewboard.kde.org/r/112104/diff/1/?file=179771#file179771line46>
> >
> >     just checking: you are not getting a "no newline at end of file" warning here?
> 
> Guy Maurel wrote:
>     No.
>     Many files have an empty line (some one more than one) at the end of the code.
>     I suppress that as I found it.

if I revert the "last line delete" I get
git apply -R -v /home/Notizen/diffs/akonadi/server/src/handler/login.diff
Checking patch server/src/handler/login.cpp...
/home/Notizen/diffs/akonadi/server/src/handler/login.diff:20: new blank line at EOF.
+
Applied patch server/src/handler/login.cpp cleanly.
warning: 1 line adds whitespace errors.
This is normal. git signals us, the last line is empty, what I found and delete just before.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112104/#review37871
-----------------------------------------------------------


On Aug. 15, 2013, 5:43 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112104/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 5:43 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil, Kevin Krammer, and Volker Krause.
> 
> 
> Description
> -------
> 
> next job
> 
> 
> Diffs
> -----
> 
>   server/src/handler/login.cpp fb6ef5d 
> 
> Diff: http://git.reviewboard.kde.org/r/112104/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/