[Kde-pim] Review Request 112209: replace name with parameter, coding style for searchhelper.cpp

Dan Vrátil dvratil at redhat.com
Thu Aug 22 14:49:35 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112209/#review38345
-----------------------------------------------------------



server/src/handler/searchhelper.cpp
<http://git.reviewboard.kde.org/r/112209/#comment28356>

    I wouldn't convert this to a parameter, or at least wouldn't call it _PARAM_. It's not a parameter, but a value.


- Dan Vrátil


On Aug. 22, 2013, 3:06 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112209/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 3:06 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil, Kevin Krammer, and Volker Krause.
> 
> 
> Description
> -------
> 
> next job
> 
> 
> Diffs
> -----
> 
>   server/src/handler/searchhelper.cpp ac97539 
>   libs/protocol_p.h 41f3f40 
> 
> Diff: http://git.reviewboard.kde.org/r/112209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list