[Kde-pim] Review Request 112016: Populate "To Desktop" menu

Sergio Luis Martins iamsergio at gmail.com
Sun Aug 11 14:29:29 BST 2013



> On Aug. 11, 2013, 1:28 p.m., Sergio Luis Martins wrote:
> > Ship It!

We commit to 4.11 and merge 4.11 into master usually.
You don't need to do the merging, we can do it.


- Sergio Luis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112016/#review37512
-----------------------------------------------------------


On Aug. 11, 2013, 1:24 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112016/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2013, 1:24 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The slot was never called. The action is initially disabled, because there are no menu items yet.
> 
> The fix is trivial, but not sure how you handle commits. Commit to 4.11 then cherry-pick or merge to master?
> 
> 
> This addresses bug 247612.
>     http://bugs.kde.org/show_bug.cgi?id=247612
> 
> 
> Diffs
> -----
> 
>   knotes/knote.cpp b4e5a8a 
> 
> Diff: http://git.reviewboard.kde.org/r/112016/diff/
> 
> 
> Testing
> -------
> 
> The slot is indeed called on every menu invocation now.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list