[Kde-pim] Review Request 112008: Fix cmake checks for Grantlee dependency

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112008/#review37732
-----------------------------------------------------------

Ship it!


makes sense. Thanks

- Christophe Giboudeaux


On Aug. 11, 2013, 1:43 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112008/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2013, 1:43 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> If Grantlee is not found or is too old, cmake fails abruptly in messageviewer/grantleefilters/CMakeLists.txt due to missing cmake definitions, and does not inform the user that Grantlee is required or what version or Grantlee is required. The patch encloses this cmake code in a conditional to allow cmake to run to completion and display a list of missing REQUIRED packages.
> 
> Since Grantlee is now a hard dependency, the QUIET keyword is also removed from the Grantlee find_package() call., 
> 
> 
> Diffs
> -----
> 
>   messageviewer/grantleefilters/CMakeLists.txt 276d7c7 
> 
> Diff: http://git.reviewboard.kde.org/r/112008/diff/
> 
> 
> Testing
> -------
> 
> cmake was run with Grantlee missing, at version 0.1.4 and version 0.3.0. The first two cases list Grantlee in the missing REQUIRED packages at the end of cmake's run, while in the last case cmake succeeds.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/