[Kde-pim] Review Request 112111: Extract the gid even if the payload is ignored, and make updating the gid optional.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112111/#review38205
-----------------------------------------------------------

Ship it!


Thanks, just change the name before committing please.


akonadi/itemmodifyjob.h
<http://git.reviewboard.kde.org/r/112111/#comment28233>

    Add what default value/behavior is and "@since 4.12" please
    
    
    



akonadi/itemmodifyjob.h
<http://git.reviewboard.kde.org/r/112111/#comment28234>

    Could you please rename this method to setUpdateGid( bool update ) to be consistent with setIgnorePayload() rather than disableRevisionCheck()? The "command-like" API is not really consistent with what we do everywhere else.
    
    Remember to update documentation :)
    
    
    


- Dan Vrátil


On Aug. 19, 2013, 8:01 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112111/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 8:01 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Volker Krause.
> 
> 
> Description
> -------
> 
> Extract the gid even if the payload is ignored, and make updating the gid optional.
> 
> This is required so we can rewrite the gid without having set the payload again.
> 
> 
> Diffs
> -----
> 
>   akonadi/tests/gidtest.cpp 13d3f4dee08b1fa943f9dc2d1fa9723840db0691 
>   akonadi/itemmodifyjob.cpp 5aa9c2e8fb7ec17ebf7b213041f141f1c879c089 
>   akonadi/itemmodifyjob.h d22d22f8f9b882f6624967b2056ce46df7e55698 
>   akonadi/gid/gidextractor_p.h 95a6ead9eb9ce57b4a31366ed032af68681c87de 
>   akonadi/gid/gidextractor.cpp 63c1296f72afa1b439ba61754e3f881f7e0a9f3c 
> 
> Diff: http://git.reviewboard.kde.org/r/112111/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/