[Kde-pim] Review Request 112334: coding style for dbinitializer_p.cpp
Dan Vrátil
dvratil at redhat.com
Thu Aug 29 14:17:09 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112334/#review38843
-----------------------------------------------------------
Ship it!
No, the index type either "PRIMARY KEY", "UNIQUE" or nothing (plain index).
- Dan Vrátil
On Aug. 28, 2013, 7:07 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112334/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 7:07 p.m.)
>
>
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
>
>
> Description
> -------
>
> don't we need a "else"-case at lines 164 and 253?
>
>
> Diffs
> -----
>
> server/src/storage/dbinitializer_p.cpp c4bd739
>
> Diff: http://git.reviewboard.kde.org/r/112334/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list