[Kde-pim] Review Request 112132: NepomukFeeder: Do not index any attachments

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112132/#review38272
-----------------------------------------------------------

Ship it!


- Christian Mollekopf


On Aug. 17, 2013, 12:09 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112132/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 12:09 p.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Description
> -------
> 
>     NepomukFeeder: Do not index any attachment content
>     
>     Given that we are not saving any information that can be used later it
>     does not make much sense to index the attachment. All we were saving was
>     the name and description of the attachment (sometimes).
>     
>     This reduces the number of statements that need to be pushed by 6-8
> 
> At some future point one should save some useful information about the attachment which can then be used in search results. Till then, there is no point of this existing.
> 
> 
> Diffs
> -----
> 
>   agents/nepomukfeeder/plugins/nepomukmailfeeder.cpp 74aad8d 
> 
> Diff: http://git.reviewboard.kde.org/r/112132/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/