[Kde-pim] Review Request 112013: kmail-mobile: add space to the accounts page

[Kevin Krammer]

> On Aug. 11, 2013, 6:27 p.m., Kevin Krammer wrote:
> > hmm, most other spacing seems to be done in pixels, why does this one have to be related to font?
> 
> Michael Bohlender wrote:
>     pixel based spacing will give bad results on screens with high pixel density. they seem to becoming more common on tablets so we should prepare for this. I tried to make every layout relational and not pixel based but I might have missed some.
> 
> Kevin Krammer wrote:
>     Right. I'd like to get Thomas' opinion on that and maybe from the Plasma people. they must be facing similar things.
>
> 
> Michael Bohlender wrote:
>     sure. have a look at my very first review request for plasma active: https://git.reviewboard.kde.org/r/109595/ 
>     I assumed I should do the same thing for spaces. Do you want me to write a mail to the plasma active mailing list and put you in CC ?

Yes, I think that would be wise. I am subscribed to plasma-active so you don't have to CC me.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112013/#review37530
-----------------------------------------------------------


On Aug. 11, 2013, 5:47 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112013/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2013, 5:47 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> adds some space to the accounts page. includes two styling fixes
> 
> 
> Diffs
> -----
> 
>   mobile/mail/AccountsPage.qml 0e65bc3 
>   mobile/mail/SettingsPage.qml 27f17e5 
> 
> Diff: http://git.reviewboard.kde.org/r/112013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/