[Kde-pim] Review Request 111742: Renabled signature url for fingerprint lookup via kleopatra

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111742/#review37188
-----------------------------------------------------------



messageviewer/viewer/objecttreeparser.cpp
<http://git.reviewboard.kde.org/r/111742/#comment27514>

    my guess style wise would be
    if ( cryptProto ) {



messageviewer/viewer/objecttreeparser.cpp
<http://git.reviewboard.kde.org/r/111742/#comment27515>

    stray development debug output?


- Kevin Krammer


On Aug. 2, 2013, 12:50 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111742/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 12:50 p.m.)
> 
> 
> Review request for Akonadi and Lindsay Mathieson.
> 
> 
> Description
> -------
> 
> Added a url to the signature html in the message display for looking up the signature fingerprint via the kleopatra keysearch dialog. This simplifies the verification and addition of public keys. 
> The url invokes kleopatra with the args "--parent-windowsid <kmail window id> --query <fingerprint>"
> 
> To use it, select a kmail message that is cryptographically signed and click on the "Show Details" link of the signature status in the message view. It will be expanded to show the signature details:
> - "Message was signed by <person name> (Key ID: <fingerprint>)"
> 
> Click on the fingerprint link to invoke kleopatra with the details. kleopatra will display the key detail if found in the local db, otherwise a keyserver search dialog prefilled with the key fingerprint.
> 
> 
> Diffs
> -----
> 
>   messageviewer/viewer/objecttreeparser.cpp 3d26ced 
>   messageviewer/viewer/urlhandlermanager.cpp 3186ac1 
> 
> Diff: http://git.reviewboard.kde.org/r/111742/diff/
> 
> 
> Testing
> -------
> 
> Viewed msgs with known and unknown signatures, using the signature link to invoke a vs of kleopatra that supports "--query" (see review 111741).
> Signature details were correctly found in kleopatra.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/