[Kde-pim] Review Request 111929: NepomukFeeder IndexScheduler: Report accurate percentage for items being removed

[Vishesh Handa]

> On Aug. 7, 2013, 2 p.m., Christian Mollekopf wrote:
> > If removals need to be scheduled now as well, I think it would be better to deal with them in a separate removalQueue, with the lowest priority, just as the indexing queues. It also seems a bit counter intuitive that the progress signal is first used for indexing and then for removal, while the counters are handled internally separately. IMO they should either be combined (just counting operations), or really be separated completely (if the two i.e. can run in parallel).
> > 
> > But feel free to ship it if this solves your needs for the moment.

I don't want to do them in parallel because virtuoso doesn't handle concurrent read and writes very well, but I totally agree that there should be a separate removal queue. I'll try to add that in a later patch. 


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111929/#review37279
-----------------------------------------------------------


On Aug. 7, 2013, 8:30 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111929/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 8:30 a.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Description
> -------
> 
>     Item removal seems to be a lot more CPU intensive than email indexing
>     because of all the optimizations. The user should therefore be given a %
>     that they can keep track of. Without this patch it just shows 0% or
>     100%.
> 
> 
> Diffs
> -----
> 
>   agents/nepomukfeeder/indexscheduler.h 9e03280 
>   agents/nepomukfeeder/indexscheduler.cpp 557cce2 
> 
> Diff: http://git.reviewboard.kde.org/r/111929/diff/
> 
> 
> Testing
> -------
> 
> Shows accurate % for item removal. Not tested to see if it still shows accurate % for items being indexed. That'll take me a couple of more hours as I have some 13k emails that need to deleted.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/