[Kde-pim] Review Request 111818: Server-side notification filtering (client side)

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111818/
-----------------------------------------------------------

(Updated Aug. 2, 2013, 1:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Description
-------

The Monitor no longer checks whether notification matches it's criteria, it only calls isLazilyIgnored() to prevent fetching Items from Akonadi when nobody's listening to the signal. The filtering code (MonitorPrivate::acceptNotification()) has not been removed though, because it's still needed when we change the filter criteria to drop pending notifications from queue.

Each Monitor is now subscribed with an unique ID, which is needed by the server to be able to distinguish between two Monitors within the same process.


I also removed the part of ChangeMediator which subscribes to notifications. It does it only so that it can re-emit the notification via it's notify() signal, but nothing actually listens to it (the whole class looks like it is not completely finished (??) and is used only on one or two places).


Diffs
-----

  akonadi/changemediator_p.h d59b981 
  akonadi/changemediator_p.cpp 9f1983c 
  akonadi/changenotificationdependenciesfactory.cpp a5d5cc0 
  akonadi/entitycache_p.h d14f8cf 
  akonadi/monitor.cpp aa8cd63 
  akonadi/monitor_p.h 9b8ea3b 
  akonadi/monitor_p.cpp 57e5d2e 
  akonadi/tests/entitycachetest.cpp e8a68a2 

Diff: http://git.reviewboard.kde.org/r/111818/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/