[Kde-pim] Review Request 111884: replace name with parameter for akappend

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111884/#review37167
-----------------------------------------------------------


Thanks!

I think it would make sense to replace parameters below with macros


server/src/handler/akappend.cpp
<http://git.reviewboard.kde.org/r/111884/#comment27496>

    Maybe we could replace this with AKONADI_FLAG_MIMETYPE?
    
    Same for the others starting with double backslash



server/src/handler/akappend.cpp
<http://git.reviewboard.kde.org/r/111884/#comment27497>

    Let's make this AKONADI_ATTRIBUTE_HIDDEN


- Dan Vrátil


On Aug. 5, 2013, 11:16 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111884/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 11:16 a.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Volker Krause.
> 
> 
> Description
> -------
> 
> 3. part of my TODO
> 
> 
> Diffs
> -----
> 
>   server/src/handler/akappend.cpp 580df8a 
> 
> Diff: http://git.reviewboard.kde.org/r/111884/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/