[Kde-pim] Review Request 112384: coding style for storagedebugger.cpp
Guy Maurel
guy-kde at maurel.de
Sat Aug 31 17:41:19 BST 2013
> On Aug. 31, 2013, 12:48 p.m., Dan Vrátil wrote:
> > server/src/storage/storagedebugger.cpp, line 49
> > <http://git.reviewboard.kde.org/r/112384/diff/1/?file=185762#file185762line49>
> >
> > I think we don't use this in Akonadi, the original formatting was correct here (just add spaces around ":")
>
> Guy Maurel wrote:
> Yes, we use this at many places!
> The best example is akonadi/server/src/akonadi.cpp lines 72 to 81.
> I think, this formatting is very nice to read, and very convenient by debbuging if one want to make a breakpoint at some lines of these.
see also akonadiconnection.cpp lines 44 to 56.
- Guy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112384/#review39015
-----------------------------------------------------------
On Aug. 30, 2013, 5:37 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112384/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2013, 5:37 p.m.)
>
>
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
>
>
> Description
> -------
>
> next job
>
>
> Diffs
> -----
>
> server/src/storage/storagedebugger.cpp 31817f3
>
> Diff: http://git.reviewboard.kde.org/r/112384/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list