[Kde-pim] Review Request 112130: Implements session restore

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112130/#review38022
-----------------------------------------------------------



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/112130/#comment28108>

    QWidget::setVisible(bool)



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/112130/#comment28109>

    I think you are in the application class here, so you could call isSessionRestored() directly



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/112130/#comment28110>

    return missing?



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/112130/#comment28111>

    "to"?
    the parameter was called "on" in the header. should be consistent IMHO



kleopatra/mainwindow_desktop.h
<http://git.reviewboard.kde.org/r/112130/#comment28112>

    style of the other event handlers suggest that this should have spaces more like
    ( QHideEvent * )



kleopatra/mainwindow_desktop.h
<http://git.reviewboard.kde.org/r/112130/#comment28113>

    see above



kleopatra/mainwindow_desktop.h
<http://git.reviewboard.kde.org/r/112130/#comment28114>

    see above



kleopatra/mainwindow_desktop.cpp
<http://git.reviewboard.kde.org/r/112130/#comment28115>

    kDebug() already prints the methods name



kleopatra/mainwindow_desktop.cpp
<http://git.reviewboard.kde.org/r/112130/#comment28116>

    Hmm, I think since you pass geometry() as the default for readEntry() that this will always be true. Maybe pass QRect() as the default?



kleopatra/systrayicon.cpp
<http://git.reviewboard.kde.org/r/112130/#comment28117>

    going by the rest of the file I'd say this goes onto the same line as "else"


- Kevin Krammer


On Aug. 17, 2013, 7:07 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112130/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 7:07 a.m.)
> 
> 
> Review request for KDEPIM and Lindsay Mathieson.
> 
> 
> Description
> -------
> 
> Adds:
> - Session restore
> - Saving of MainWindow geometry and visible state
> - Toggling of visibility by clicking SysTrayIcon.
> - Splash screen is not shown when restoring session.
> 
> Internal behaviour change. To enable preservation of state when the session is being saved, the MainWindow is no longer closed and deleted when minimising to the system tray, rather it is hidden.
> 
> 
> This addresses bug 309461.
>     http://bugs.kde.org/show_bug.cgi?id=309461
> 
> 
> Diffs
> -----
> 
>   kleopatra/kleopatraapplication.h 202c937 
>   kleopatra/kleopatraapplication.cpp 91c07cf 
>   kleopatra/main.cpp 572242d 
>   kleopatra/mainwindow_desktop.h d02f6c4 
>   kleopatra/mainwindow_desktop.cpp 55efd91 
>   kleopatra/systrayicon.h 2621985 
>   kleopatra/systrayicon.cpp 5a5cd2e 
> 
> Diff: http://git.reviewboard.kde.org/r/112130/diff/
> 
> 
> Testing
> -------
> 
> - Start kleopatra. 
> * Log out/in, the MainWindow will be restored to its previous screen position.
> 
> - Start kleopatra, minimise window to tray. 
> * Log out/in, the MainWindow will be restored to the tray. Click the tray icon and the MainWindow will be restored to its previous screen position. 
> 
> - Start Kmail. 
>   * Choose "Tools|Certificate Manager". kleopatra will be started.
>   * Click on a signature thumprint in a signed message. The kleopatra key search or detail dilaog will be displayed.
> 
> 
> - Start kleopatra
> - Start Kmail. 
>   * Choose "Tools|Certificate Manager". kleopatra will be displayed.
>   * Click on a signature thumbprint in a signed message. The kleopatra key search or detail dialog will be displayed.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/