[Kde-pim] Review Request 111873: Minimise kleopatra to system tray on startup

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111873/#review38011
-----------------------------------------------------------


For me seems good

- Laurent Montel


On Aug. 17, 2013, 6:53 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111873/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 6:53 a.m.)
> 
> 
> Review request for KDEPIM and Andre Heinecke.
> 
> 
> Description
> -------
> 
> Currently kleopatra always displays its main window on startup, which is annoying on logon when it should be just displaying in the tray (note: kleopatra always displays in the tray, there is no option to disable this).
> This patch:
> - keeps the main window hidden on startup
> - adds a command line option "--show" to display the main window on request
> - adds the "--show" option to kdepims Tools|Certificate Manager" menu action
> 
> Note 2: This is identical behaviour to kgpg.
> 
> 
> This addresses bug 309461.
>     http://bugs.kde.org/show_bug.cgi?id=309461
> 
> 
> Diffs
> -----
> 
>   kleopatra/kleopatraapplication.cpp 91c07cf 
>   kmail/kmmainwidget.cpp ce24d3e 
> 
> Diff: http://git.reviewboard.kde.org/r/111873/diff/
> 
> 
> Testing
> -------
> 
> From Cmd line:
> - "kleopatra". System Tray Icon is displayed, no main window
> - "kleopatra --show". System Tray Icon and Main Window are displayed
> - KMail - "Tools|Certificate Manager". Kleopatra main window is displayed.
> - Reboot. Just the system tray icon is displayed
> - Logout/Login. Just the system tray icon is displayed
> - From kleopatra System Tray Context Menu:
>   * Open Certificate Manager
>   * Configure Kleopatra
>   * About Kleopatra
>   All windows were displayed as expected.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/