[Kde-pim] Review Request 111741: Implements --query command

Lindsay Mathieson lindsay.mathieson at gmail.com
Fri Aug 2 13:11:57 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111741/
-----------------------------------------------------------

(Updated Aug. 2, 2013, 10:11 p.m.)


Review request for Akonadi, Lindsay Mathieson and Volker Krause.


Changes
-------

- Code style fixes
- fingerprint is now looked up in local db first and detail displayed if found, otherwise the external keyserver search dialog is displayed.
- accepts a --parent-windowid <windowId>  command line parameter that is used for parenting the search and detail dialogs to the calling app. This allows them to display above the calling app as expected.

Example usage:

kleopatra --parent-windowid 0 --query 04b8b187


Description
-------

Added support for "--query <fingerprint>" command. Pre-loads search field and starts default keyserver search.


This addresses bug 175980.
    http://bugs.kde.org/show_bug.cgi?id=175980


Diffs (updated)
-----

  kleopatra/commands/lookupcertificatescommand.h 80215fd 
  kleopatra/commands/lookupcertificatescommand.cpp 7f96146 
  kleopatra/dialogs/lookupcertificatesdialog.h b8fa78f 
  kleopatra/dialogs/lookupcertificatesdialog.cpp b50bcd4 
  kleopatra/kleopatraapplication.cpp 13590c9 

Diff: http://git.reviewboard.kde.org/r/111741/diff/


Testing
-------

Started kleopatra from console with various options such as:

  kleopatra --query 04b8b187

Keysearch dialog is displayed with correct parameters.


Thanks,

Lindsay Mathieson

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list