[Kde-pim] Review Request 112249: replace name with parameter, coding style for store.*

Guy Maurel guy-kde at maurel.de
Mon Aug 26 16:51:29 BST 2013



> On Aug. 26, 2013, 12:28 p.m., Dan Vrátil wrote:
> > server/src/handler/store.cpp, line 177
> > <http://git.reviewboard.kde.org/r/112249/diff/2/?file=184465#file184465line177>
> >
> >     This could be replaces with AKONADI_PARAM_SILENT

we have already AKONADI_PARAM_SILENT, used by select.cpp
I propose AKONADI_PARAM_DOT_SILENT


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112249/#review38617
-----------------------------------------------------------


On Aug. 26, 2013, 3:51 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112249/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 3:51 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil, Kevin Krammer, and Volker Krause.
> 
> 
> Description
> -------
> 
> nextjob
> 
> 
> Diffs
> -----
> 
>   libs/protocol_p.h 3d92592 
>   server/src/handler/store.h a0fad86 
>   server/src/handler/store.cpp 2cd2e17 
> 
> Diff: http://git.reviewboard.kde.org/r/112249/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list