[Kde-pim] Review Request 112163: replace name with parameter, coding style for modify.cpp

Kevin Krammer krammer at kde.org
Tue Aug 20 18:47:26 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112163/#review38228
-----------------------------------------------------------



server/src/handler/modify.cpp
<http://git.reviewboard.kde.org/r/112163/#comment28250>

    almost there: {} missing here


David is of course right regarding the style as a whole, but since non of the existing spaces in () where removed this would just have been inconsitent. So as long as the original spacing rules are kept for the rest of the file they also apply for new code

- Kevin Krammer


On Aug. 20, 2013, 5:24 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112163/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 5:24 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil, Kevin Krammer, and Volker Krause.
> 
> 
> Description
> -------
> 
> next job
> 
> 
> Diffs
> -----
> 
>   libs/protocol_p.h 8e332ec 
>   server/src/handler/modify.cpp 24ee874 
> 
> Diff: http://git.reviewboard.kde.org/r/112163/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list