[Kde-pim] Review Request 111929: NepomukFeeder IndexScheduler: Report accurate percentage for items being removed

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111929/#review37259
-----------------------------------------------------------


Not commenting on the change itself, but I think it would make a lot of sense to port the agent to ObserverV3 to get batch notifications about items removal and flag changes. Especially if Nepomuk can deal with batches, the progress reporting could be completely eliminated.

- Dan Vrátil


On Aug. 7, 2013, 10:30 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111929/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 10:30 a.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Description
> -------
> 
>     Item removal seems to be a lot more CPU intensive than email indexing
>     because of all the optimizations. The user should therefore be given a %
>     that they can keep track of. Without this patch it just shows 0% or
>     100%.
> 
> 
> Diffs
> -----
> 
>   agents/nepomukfeeder/indexscheduler.h 9e03280 
>   agents/nepomukfeeder/indexscheduler.cpp 557cce2 
> 
> Diff: http://git.reviewboard.kde.org/r/111929/diff/
> 
> 
> Testing
> -------
> 
> Shows accurate % for item removal. Not tested to see if it still shows accurate % for items being indexed. That'll take me a couple of more hours as I have some 13k emails that need to deleted.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/