[Kde-pim] Review Request 112380: coding style for querybuilder.cpp

Dan Vrátil dvratil at redhat.com
Sat Aug 31 13:40:54 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112380/#review39011
-----------------------------------------------------------

Ship it!


Yes, because declaration is not allowed within the case statement (see l. 187)

- Dan Vrátil


On Aug. 30, 2013, 7:15 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112380/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 7:15 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Description
> -------
> 
> do we really need the { ... } to build a block at line 182 in a "case"-part?
> I think NO.
> 
> 
> Diffs
> -----
> 
>   server/src/storage/querybuilder.cpp 03e6da9 
> 
> Diff: http://git.reviewboard.kde.org/r/112380/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list