[Kde-pim] Review Request 111917: Corrected the text from the context menu of pasting an URL in the Kmail composer

Ovidiu-Florin Bogdan ovidiu.b13 at gmail.com
Wed Aug 7 09:18:56 BST 2013



> On Aug. 7, 2013, 6:56 a.m., Kevin Krammer wrote:
> > kmail/editor/kmcomposewin.cpp, line 2199
> > <http://git.reviewboard.kde.org/r/111917/diff/1/?file=176439#file176439line2199>
> >
> >     My suggestion would be
> >     "Add URL as Message Text"
> >     "Add URLs as Message Text"

I believe that if you say "as Text" it is clearer that it will be text and not a link.


- Ovidiu-Florin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111917/#review37250
-----------------------------------------------------------


On Aug. 6, 2013, 9 p.m., Ovidiu-Florin Bogdan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111917/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 9 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This function name is confusing as it leads the user to believe that the URL being pasted in the message is pasted as a URL, so I've renamed it to "Add URL into Message as Text"
> 
> 
> This addresses bug 323246.
>     http://bugs.kde.org/show_bug.cgi?id=323246
> 
> 
> Diffs
> -----
> 
>   kmail/editor/kmcomposewin.cpp eee96e5 
> 
> Diff: http://git.reviewboard.kde.org/r/111917/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ovidiu-Florin Bogdan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list