[Kde-pim] Review Request 111884: replace name with parameter for akappend
Dan Vrátil
dvratil at redhat.com
Mon Aug 5 21:11:08 BST 2013
> On Aug. 5, 2013, 11:22 a.m., Kevin Krammer wrote:
> > Did you upload the wrong diff?
> > This looks more like a style change than replacing some name
>
> Guy Maurel wrote:
> No.
> As there where some style to adjust, I make this at the same time.
>
> Kevin Krammer wrote:
> I must be blind. The only non-style change I see is an additional include.
I believe Guy's task is to "replace name with parameters and fix coding style where possible". Since there are no string to replace, this change is only mostly about style :-)
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111884/#review37109
-----------------------------------------------------------
On Aug. 5, 2013, 11:16 a.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111884/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2013, 11:16 a.m.)
>
>
> Review request for Akonadi, Dan Vrátil and Volker Krause.
>
>
> Description
> -------
>
> 3. part of my TODO
>
>
> Diffs
> -----
>
> server/src/handler/akappend.cpp 580df8a
>
> Diff: http://git.reviewboard.kde.org/r/111884/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list