[Kde-pim] Review Request 112013: kmail-mobile: add space to the accounts page

Michael Bohlender michael.bohlender at kdemail.net
Sun Aug 11 20:15:39 BST 2013



> On Aug. 11, 2013, 6:27 p.m., Kevin Krammer wrote:
> > hmm, most other spacing seems to be done in pixels, why does this one have to be related to font?

pixel based spacing will give bad results on screens with high pixel density. they seem to becoming more common on tablets so we should prepare for this. I tried to make every layout relational and not pixel based but I might have missed some.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112013/#review37530
-----------------------------------------------------------


On Aug. 11, 2013, 5:47 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112013/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2013, 5:47 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> adds some space to the accounts page. includes two styling fixes
> 
> 
> Diffs
> -----
> 
>   mobile/mail/AccountsPage.qml 0e65bc3 
>   mobile/mail/SettingsPage.qml 27f17e5 
> 
> Diff: http://git.reviewboard.kde.org/r/112013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list