[Kde-pim] Review Request 111946: speedup a little
Volker Krause
vkrause at kde.org
Fri Aug 9 14:50:14 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111946/#review37424
-----------------------------------------------------------
Are you sure about this? sInstance.exists() is false when state() is called from the ServerManager::Private ctor. Yet it can return a state != NotRunning in this case, which is used to initialize itself correctly.
- Volker Krause
On Aug. 9, 2013, 1:28 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111946/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 1:28 p.m.)
>
>
> Review request for KDEPIM-Libraries, Dan Vrátil and Volker Krause.
>
>
> Description
> -------
>
> as the "sInstance" doesn't exist [ sInstance.exists() is false], it is not necessary to go on.
>
>
> Diffs
> -----
>
> akonadi/servermanager.cpp db6492d
>
> Diff: http://git.reviewboard.kde.org/r/111946/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list