[Kde-pim] Review Request 110213: Fixes Bug 314422 - Akonadi Plugin: Better placeholders

[Peter Grasch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110213/#review31655
-----------------------------------------------------------



plugins/Commands/Akonadi/akonadiconfiguration.cpp
<http://git.reviewboard.kde.org/r/110213/#comment23563>

    With the updated format, the comment for the translators doesn't really make sense anymore. Change it to something like "%summary, %date, %time and %location will be filled in later with appropriate values".
    
    Moreover, the comment about the "missing" arguments no longer applies. This was there as i18n(c) shows a warning when there are arguments (%\d+) but no values. This is no longer the case, remove it.



plugins/Commands/Akonadi/akonadiconfigurationdlg.ui
<http://git.reviewboard.kde.org/r/110213/#comment23564>

    You're starting your variables with an upper case letter here despite using all lowercase everywhere else.
    
    Make them lowercase here too.



plugins/Commands/Akonadi/alarmscheduleitem.cpp
<http://git.reviewboard.kde.org/r/110213/#comment23565>

    Even if you're using lower case consistently, I'd still replace case insensitive here.
    I suspect that many users will use %Summary and %summary interchangeably.


- Peter Grasch


On April 27, 2013, 7:56 a.m., Vedant Agarwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110213/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 7:56 a.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> Earlier (%1, %2, %3, %4) were the placeholders used by Akonadi plugins reminder system for (summary, date, time, location). Now the placeholders are (%summary, %date, %time, %location).
> 
> 
> This addresses bug 314422.
>     http://bugs.kde.org/show_bug.cgi?id=314422
> 
> 
> Diffs
> -----
> 
>   plugins/Commands/Akonadi/alarmscheduleitem.cpp 3c924b1 
>   plugins/Commands/Akonadi/akonadiconfigurationdlg.ui e75f472 
>   plugins/Commands/Akonadi/akonadiconfiguration.cpp ad52e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/110213/diff/
> 
> 
> Testing
> -------
> 
> Builds and installs successfully.
> 
> 
> Thanks,
> 
> Vedant Agarwala
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/