[Kde-pim] Review Request 109936: Only single empty lines, First line, last line(s) may not be empty for kdepimlibs/kimap

Kevin Ottens ervin at kde.org
Wed Apr 10 22:45:17 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109936/#review30874
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On April 9, 2013, 3:51 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109936/
> -----------------------------------------------------------
> 
> (Updated April 9, 2013, 3:51 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Andras Mantia, Kevin Ottens, and Volker Krause.
> 
> 
> Description
> -------
> 
> According the discussion in Berlin KDEPIM-Meeting and http://techbase.kde.org/Policies/Kdepim_Coding_Style#Migration
> I remove multi empty lines, first empty line and last empty line(s).
> 
> 
> Diffs
> -----
> 
>   kimap/acl.cpp d5f52a0 
>   kimap/acljobbase.cpp 7efc875 
>   kimap/appendjob.cpp 83093a8 
>   kimap/capabilitiesjob.cpp 49f6fea 
>   kimap/closejob.cpp 47db3bf 
>   kimap/copyjob.cpp 80586b9 
>   kimap/createjob.cpp db6d903 
>   kimap/deleteacljob.cpp 56c1bbf 
>   kimap/deletejob.cpp f93ef99 
>   kimap/expungejob.cpp 9a61e6a 
>   kimap/fetchjob.cpp e124c9d 
>   kimap/getacljob.h 41d815e 
>   kimap/getacljob.cpp f526d64 
>   kimap/getmetadatajob.cpp cbca3c6 
>   kimap/getquotajob.cpp be427c6 
>   kimap/getquotarootjob.cpp 687865f 
>   kimap/imapset.cpp ea43000 
>   kimap/imapstreamparser.h db52d81 
>   kimap/imapstreamparser.cpp c6e8932 
>   kimap/job.cpp 5e58b68 
>   kimap/listrightsjob.h 60b1e2b 
>   kimap/listrightsjob.cpp 6ef0545 
>   kimap/loginjob.cpp 816d72f 
>   kimap/logoutjob.cpp aa621c8 
>   kimap/metadatajobbase.cpp 70293ee 
>   kimap/myrightsjob.cpp d203e83 
>   kimap/namespacejob.cpp bf1192d 
>   kimap/quotajobbase.cpp 936d378 
>   kimap/renamejob.cpp 4046af6 
>   kimap/searchjob.cpp 6b9ebe5 
>   kimap/selectjob.cpp 61d1121 
>   kimap/sessionlogger.cpp 6792a94 
>   kimap/sessionthread.cpp 18e22ff 
>   kimap/setacljob.h 900b255 
>   kimap/setacljob.cpp 1b89e3d 
>   kimap/setmetadatajob.cpp b77229b 
>   kimap/setquotajob.cpp beeab17 
>   kimap/storejob.cpp 3d4b3ce 
>   kimap/subscribejob.cpp ad8ee52 
>   kimap/tests/capabilitiesjobtest.cpp e452428 
>   kimap/tests/fetchjobtest.cpp 6067de0 
>   kimap/tests/idlejobtest.cpp 0416b53 
>   kimap/tests/kimaptest/fakeserver.h 22b970c 
>   kimap/tests/kimaptest/fakeserver.cpp ce368e8 
>   kimap/tests/kimaptest/mockjob.h ed22be9 
>   kimap/tests/kimaptest/mockjob.cpp 5b1bc82 
>   kimap/unsubscribejob.cpp 984f14e 
> 
> Diff: http://git.reviewboard.kde.org/r/109936/diff/
> 
> 
> Testing
> -------
> 
> Tested for CMAKE_BUILD_TYPE "release" and "debug" with http://techbase.kde.org/Policies/Kdepim_Coding_Style#Check_the_assembler_files
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list