[Kde-pim] Review Request 110127: Allow to explicitly block only some types of alarms in BlockAlarmsAttribute

[Sergio Luis Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110127/#review31789
-----------------------------------------------------------



akonadi/calendar/etmcalendar.cpp
<http://git.reviewboard.kde.org/r/110127/#comment23700>

    I don't think we can remove alarms from the incidence here.
    
    On the next ItemModifyJob, done by a calendarview, it will then remove the alarm from the backend.


- Sergio Luis Martins


On April 22, 2013, 2:32 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110127/
> -----------------------------------------------------------
> 
> (Updated April 22, 2013, 2:32 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Andras Mantia.
> 
> 
> Description
> -------
> 
> This patch allows user to block only specific type of alarms. The default behavior is to block all types.
> 
> This way the Google Calendar resource can prevent KOrgac from sending email alerts, because Google will send them for us (see https://bugs.kde.org/show_bug.cgi?id=318392 for details).
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/blockalarmsattribute.h 265ff36 
>   akonadi/calendar/blockalarmsattribute.cpp 962e98e 
>   akonadi/calendar/etmcalendar.cpp 1f27cbe 
> 
> Diff: http://git.reviewboard.kde.org/r/110127/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/