[Kde-pim] Review Request 110153: Allow search through attendees in korganizer

[Christian Mollekopf]

> On April 24, 2013, 2:35 p.m., Sergio Luis Martins wrote:
> > korganizer/searchdialog.cpp, line 233
> > <http://git.reviewboard.kde.org/r/110153/diff/2/?file=140748#file140748line233>
> >
> >     Maybe not break here ?

This only breaks the inner loop. Once the item was added to the list there is no need to evaluate any further attendees.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110153/#review31497
-----------------------------------------------------------


On April 24, 2013, 11:30 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110153/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 11:30 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This patch allows search through attendees of an incidence. That way I can i.e. search for all events where I attend.
> By searching through fullName it's possible to match both email address and name.
> 
> 
> Diffs
> -----
> 
>   korganizer/searchdialog.cpp a23f20f 
>   korganizer/searchdialog_base.ui 96902e5 
> 
> Diff: http://git.reviewboard.kde.org/r/110153/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/