[Kde-pim] Review Request 109914: [IMAP] Use itemsRetrievedIncremental() when fetching missing bodies

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109914/
-----------------------------------------------------------

(Updated April 9, 2013, 12:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM.


Description
-------

After RetrieveItemsTask finishes retrieving new emails or missing bodies, it fetches flags of emails 1...firstFetchedEmail. But in case of missing bodies fetch, the firstFetchedEmail does not have to be the newest item in the folder, so flags of (firstFetchedEmail + 1)...lastEmailInFolder are never retrieved and calling itemsRetrievalDone() causes Akonadi to drop all the messages in this range, as described in the referenced bug.

Using itemsRetrievedIncremental() when retrieving missing bodies fixes the issue, and I think it also makes more sense in this context, because syncing flags should be only done during regular sync.


This addresses bug 316521.
    http://bugs.kde.org/show_bug.cgi?id=316521


Diffs
-----

  resources/imap/retrieveitemstask.cpp 5129297 

Diff: http://git.reviewboard.kde.org/r/109914/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/