[Kde-pim] Review Request 110011: Fix Bug #282982 - Violation of RfC 2633 Chapter 3.8

[Sandro Knauß]

> On April 15, 2013, 6:47 a.m., Laurent Montel wrote:
> > Seems good,
> > but can't use "make test"
> > it fails:
> > 2/4 Test #2: messageviewer-objecttreeparsertest .....   Passed    0.23 sec
> >     Start 3: messageviewer-rendertest
> > 3/4 Test #3: messageviewer-rendertest ...............***Failed    0.72 sec
> >     Start 4: messageviewer-unencryptedmessagetest
> > 4/4 Test #4: messageviewer-unencryptedmessagetest ...***Failed    0.26 sec
> > 
> > it's not your patch I tested without it, but I don't verify that it's correct.
> > Regards

I know, that "make test" doesn't work in master and KDE.4.10. Actually the most failing tests in kdepim are related to the crypto issue i fixed on review #109434 two weeks ago.
A workaround (GNUPGHOME have to point to the build directory of messagecore/tests/gnupg_home):
GNUPGHOME=~/kde/build/kdepim/messagecore/tests/gnupg_home
gpg-agent --daemon make test


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110011/#review31054
-----------------------------------------------------------


On April 14, 2013, 2:53 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110011/
> -----------------------------------------------------------
> 
> (Updated April 14, 2013, 2:53 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Fix Bug #282982 - Violation of RfC 2633 Chapter 3.8
> 
> Violation of RfC 2633 Chapter 3.8 - smime.p7m is not recognized as
> encrypted mail, not encrypted, displayed in-line when the content-type
> is application/octet-stream.
> 
> BUG: 282982
> FIXED-IN: 4.10.3
> REVIEW: 110011
> 
> 
> This addresses bug 282982.
>     http://bugs.kde.org/show_bug.cgi?id=282982
> 
> 
> Diffs
> -----
> 
>   messageviewer/objecttreeparser.cpp 9ceea2285761632ee49e6a97b50eec82bb6e5581 
> 
> Diff: http://git.reviewboard.kde.org/r/110011/diff/
> 
> 
> Testing
> -------
> 
> adding tests mails for this bug under /messageviewer/tests/data/smime-encrypted* .
> 
> Open /messageviewer/tests/data/smime-encrypted-octet-stream.mbox:
> -> Mail will be shown as Encrypted Message with content:
> "The quick brown fox jumped over the lazy dog."
> 
> Testing attached mail at bug report.
> -> Mail will be shown as Encrypted Message(Decryption not Possible), Reason:No Secret Key
> -> an Icon to click at to open the attached file.
> 
> Testing with image attached with name "smime.p7m" amd application/octet-stream
> -> Mail will be shown as Encrypted Message(Decryption not Possible), Reason: End of File
> -> an Icon to click to open the attached file.
> 
> run make test
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/