[Kde-pim] Review Request: Make ldap resource configuration fields more obvious

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106510/#review19221
-----------------------------------------------------------

Ship it!


I can't think of a reason why not. :)

- Allen Winter


On Sept. 19, 2012, 11:17 p.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106510/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 11:17 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> I have tried many times to set up an ldap addressbook in kmail and kaddressbook.  Today I tried and succeeded both in the ldap kcm and in kaddressbook ldap resource.  I found that the ldapconfigwidget used in the ldap resource was not as easy to figure out which fields needed values as the one in the ldap kcm.  I found out the reason is that the ldap resource uses two ldapconfig widgets, one for basic settings, the other for security settings, thus the secutiry radio buttons were on the second one didn't have a way to enable and disable the widgets on the first page.
> 
> This patch changes the ldap resource to use one ldapconfig widget rather than two, which fixes the issue.
> 
> 
> Diffs
> -----
> 
>   kabc/plugins/ldapkio/resourceldapkioconfig.h 7762d11d1f574bc7a181d58c8f9f7738b2b0410a 
>   kabc/plugins/ldapkio/resourceldapkioconfig.cpp 1b6e7eace5fc8cca160f965b991ff6a811edb091 
> 
> Diff: http://git.reviewboard.kde.org/r/106510/diff/
> 
> 
> Testing
> -------
> 
> It works fine here.
> 
> 
> Screenshots
> -----------
> 
> New ldap resource config
>   http://git.reviewboard.kde.org/r/106510/s/732/
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/