[Kde-pim] Review Request: Tidy Agent Instance Delegate

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106640/#review19629
-----------------------------------------------------------

Ship it!


Looks good to me, thanks!


akonadi/agentinstancewidget.cpp
<http://git.reviewboard.kde.org/r/106640/#comment15628>

    looks like those two could be const



akonadi/agentinstancewidget.cpp
<http://git.reviewboard.kde.org/r/106640/#comment15629>

    those three look const as well.



akonadi/agentinstancewidget.cpp
<http://git.reviewboard.kde.org/r/106640/#comment15630>

    and this one as well



akonadi/agentinstancewidget.cpp
<http://git.reviewboard.kde.org/r/106640/#comment15631>

    and two more const


- Volker Krause


On Sept. 29, 2012, 9 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106640/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2012, 9 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> This fixes the oversized icons, aligns the text better with the main icon, and fixes the vertical alignment between the status icon and the status text.
> 
> In the process I moved from the QTextDocument to native painting to get the required extra control over padding/margin.
> 
> 
> Diffs
> -----
> 
>   akonadi/agentinstancewidget.cpp bc917b4 
> 
> Diff: http://git.reviewboard.kde.org/r/106640/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/106640/s/745/
> After
>   http://git.reviewboard.kde.org/r/106640/s/746/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/