[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for kmime

Kevin Krammer krammer at kde.org
Sun Sep 2 15:36:13 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106262/#review18434
-----------------------------------------------------------



kmime/kmime_content.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14551>

    spaces around +=



kmime/kmime_content.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14552>

    spaces around -



kmime/kmime_dateformatter.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14553>

    spaces around *



kmime/kmime_parsers.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14554>

    spaces between uuStart, - and 1 and around :



kmime/kmime_util.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14555>

    spaces around <



kmime/kmime_util.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14556>

    why the {} block around this line?



kmime/kmime_util.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14557>

    Content *child



kmime/tests/auto/headertest.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14558>

    spaces in newRow() function call



kmime/tests/auto/sizetest.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14559>

    spaces in sizeof



kmime/tests/manual/test_dates.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14560>

    space between * and 30



kmime/tests/manual/test_kmime_header_parsing.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14561>

    spaces around +



kmime/tests/manual/test_kmime_header_parsing.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14562>

    spaces around +



kmime/tests/manual/test_kmime_header_parsing.cpp
<http://git.reviewboard.kde.org/r/106262/#comment14563>

    spaces around /


- Kevin Krammer


On Aug. 29, 2012, 7:31 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106262/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 7:31 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Description
> -------
> 
> same as kdepimlibs/akonadi
> 
> 
> Diffs
> -----
> 
>   kmime/boolflags.cpp 95d6981 
>   kmime/kmime_charfreq.cpp 3ec6d05 
>   kmime/kmime_codec_base64.h 7f9b251 
>   kmime/kmime_codec_base64.cpp edf666f 
>   kmime/kmime_codec_qp.h b1109d8 
>   kmime/kmime_codec_qp.cpp 9736257 
>   kmime/kmime_codec_uuencode.cpp 0b84610 
>   kmime/kmime_codecs.cpp 790c3a2 
>   kmime/kmime_content.h 05f67c2 
>   kmime/kmime_content.cpp 37ca474 
>   kmime/kmime_contentindex.h b589444 
>   kmime/kmime_contentindex.cpp a5301e5 
>   kmime/kmime_dateformatter.cpp c9a471f 
>   kmime/kmime_header_parsing.cpp ba4a2e3 
>   kmime/kmime_headerfactory.cpp 0228b5f 
>   kmime/kmime_headers.h 85e1932 
>   kmime/kmime_headers.cpp e594cb3 
>   kmime/kmime_mdn.cpp 3fc28f2 
>   kmime/kmime_message.h 3bbd137 
>   kmime/kmime_message_p.h ad33d97 
>   kmime/kmime_newsarticle.cpp b2e72ec 
>   kmime/kmime_parsers.cpp 85768ce 
>   kmime/kmime_util.cpp 64ae748 
>   kmime/tests/auto/base64benchmark.cpp 1334b09 
>   kmime/tests/auto/charfreqtest.cpp 256727b 
>   kmime/tests/auto/codectest.cpp 2ef2f5d 
>   kmime/tests/auto/contenttest.cpp 19be53b 
>   kmime/tests/auto/headerfactorytest.cpp d39fd4c 
>   kmime/tests/auto/headertest.cpp 17c52ce 
>   kmime/tests/auto/messagetest.cpp 168e22d 
>   kmime/tests/auto/rfc2047test.cpp 4377370 
>   kmime/tests/auto/sizetest.cpp cc4b81f 
>   kmime/tests/auto/utiltest.cpp 757eebe 
>   kmime/tests/manual/test_charfreq.cpp 043e380 
>   kmime/tests/manual/test_dates.cpp 69d67ed 
>   kmime/tests/manual/test_kmime_header_parsing.cpp e29af28 
>   kmime/tests/manual/test_mdn.cpp e35aa6d 
> 
> Diff: http://git.reviewboard.kde.org/r/106262/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list