[Kde-pim] Review Request: Merge akonadi-social-utils into kdepimlibs

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106631/#review19602
-----------------------------------------------------------



akonadi/socialutils/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106631/#comment15597>

    Please move these lines into the main CMakeLists.txt



akonadi/socialutils/serializer/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106631/#comment15593>

    remove



akonadi/socialutils/serializer/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106631/#comment15594>

    endif()



akonadi/socialutils/serializer/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106631/#comment15592>

    Not needed



akonadi/socialutils/serializer/README
<http://git.reviewboard.kde.org/r/106631/#comment15595>

    This file doesn't look useful anymore



akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.cpp
<http://git.reviewboard.kde.org/r/106631/#comment15590>

    #include <akonadi/item.h>



akonadi/socialutils/socialnetworkattributes.h
<http://git.reviewboard.kde.org/r/106631/#comment15596>

    #include <akonadi/attribute.h>



cmake/modules/FindQJSON.cmake
<http://git.reviewboard.kde.org/r/106631/#comment15588>

    Please add a copy of FindQJSON.cmake from the kde-workspace module instead.
    
    qjson from git now provides a config module which shall be preferred if available



cmake/modules/FindQtOAuth.cmake
<http://git.reviewboard.kde.org/r/106631/#comment15585>

    Not needed, read http://techbase.kde.org/Policies/CMake_Coding_Style#Avoid_Micro-Optimzations
    



cmake/modules/FindQtOAuth.cmake
<http://git.reviewboard.kde.org/r/106631/#comment15586>

    endif() (http://techbase.kde.org/Policies/CMake_Coding_Style#End_commands)


- Christophe Giboudeaux


On Sept. 29, 2012, 11:05 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106631/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2012, 11:05 a.m.)
> 
> 
> Review request for KDEPIM and KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> This is a final review request for merging the Akonadi Social Utils library into kdepimlibs.
> 
> Should the git history (not much in there..) be preserved as well? And if so, how should that be done? I've no experience with that :)
> 
> 
> Diffs
> -----
> 
>   akonadi/CMakeLists.txt 8778c9c 
>   akonadi/socialutils/.krazy PRE-CREATION 
>   akonadi/socialutils/CMakeLists.txt PRE-CREATION 
>   akonadi/socialutils/Mainpage.dox PRE-CREATION 
>   akonadi/socialutils/imageprovider.h PRE-CREATION 
>   akonadi/socialutils/imageprovider.cpp PRE-CREATION 
>   akonadi/socialutils/libakonadisocialutils_export.h PRE-CREATION 
>   akonadi/socialutils/serializer/CMakeLists.txt PRE-CREATION 
>   akonadi/socialutils/serializer/README PRE-CREATION 
>   akonadi/socialutils/serializer/akonadi-serializer.png PRE-CREATION 
>   akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.cpp PRE-CREATION 
>   akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.desktop PRE-CREATION 
>   akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.h PRE-CREATION 
>   akonadi/socialutils/serializer/x-vnd.akonadi.socialfeeditem.xml PRE-CREATION 
>   akonadi/socialutils/socialfeeditem.h PRE-CREATION 
>   akonadi/socialutils/socialfeeditem.cpp PRE-CREATION 
>   akonadi/socialutils/socialnetworkattributes.h PRE-CREATION 
>   akonadi/socialutils/socialnetworkattributes.cpp PRE-CREATION 
>   akonadi/socialutils/tests/CMakeLists.txt PRE-CREATION 
>   akonadi/socialutils/tests/image-provider-tests.h PRE-CREATION 
>   akonadi/socialutils/tests/image-provider-tests.cpp PRE-CREATION 
>   cmake/modules/FindQJSON.cmake PRE-CREATION 
>   cmake/modules/FindQtOAuth.cmake PRE-CREATION 
>   includes/Akonadi/SocialUtils/ImageProvider PRE-CREATION 
>   includes/Akonadi/SocialUtils/SocialFeedItem PRE-CREATION 
>   includes/Akonadi/SocialUtils/SocialNetworkAttributes PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106631/diff/
> 
> 
> Testing
> -------
> 
> Everything builds.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/