[Kde-pim] Review Request: Create HD contact photos

[Sebastian Scheibner]

> On Sept. 30, 2012, 3:18 p.m., Tobias Koenig wrote:
> > Ship It!

I don't have commit access, so it would be great if someone else committed this.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106570/#review19655
-----------------------------------------------------------


On Sept. 30, 2012, 9:46 a.m., Sebastian Scheibner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106570/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2012, 9:46 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Tobias Koenig.
> 
> 
> Description
> -------
> 
> Currently KDE pim creates contact photos with 100x100 px. That is large enough for the small thumbnails in the contacts list in kaddressbook, but looks ugly in applications that show large contact photos.
> This patch changes the maximum contact photo size to 720x720 px.
> 
> I made this patch because Android 4.1 shows nice high-resolution contact photos in the contacts app and creates contact photos with 720x720 px. Those can be synced with kaddressbook, e.g. via a carddav server. KDE PIM can handle those large photos, even though it doesn't show them larger than 100x100 in the contacts view.
> 
> The existing implementation scales all contact photos to 100x100 px, even if a photo is smaller than that. That's not a good idea, it creates unnecessarily large vcards (especially when the photo size is increased).
> 
> I also changed the parameters of the getSelectedImage() function, because they don't specify the actual size of the image but only the ratio (which is 1:1 as contact photos are square).
> 
> Of course increasing the photo size increases the size of the vcf files. A vcf with 100x100 photo has about 10kB, and with 720x720 about 80kB.
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/editor/imagewidget.cpp ebf6b54 
> 
> Diff: http://git.reviewboard.kde.org/r/106570/diff/
> 
> 
> Testing
> -------
> 
> compiled kdepimlibs/akonadi/contact with KDE 4.9.1 and added a new HD contact photo with kaddressbook and synced successfully via carddav to my smartphone.
> 
> 
> Thanks,
> 
> Sebastian Scheibner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/