[Kde-pim] Review Request: 2/4 Proper implementation of virtual collections

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106547/#review19638
-----------------------------------------------------------

Ship it!


Looks good.

One thing I missed on the server side: we need to increase the protocol version there, and require the latest version in the client side, since we are sending the "VIRTUAL" attribute now, that older versions don't understand.


akonadi/collection_p.h
<http://git.reviewboard.kde.org/r/106547/#comment15641>

    Minor optimization (somewhat unrelated to your change): make those three bools a bitfield (ie. append ":1" to all of them), should save 16 byte per collection object.



akonadi/collectionmodifyjob.cpp
<http://git.reviewboard.kde.org/r/106547/#comment15642>

    Along with the corresponding server change, let's just omit this here.


- Volker Krause


On Sept. 23, 2012, 9:24 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106547/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2012, 9:24 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> kdepimlibs-part of proper implementation of virtual collections
> 
> It converts Akonadi::Collections::isVirtual() to proper flag, adds setVirtual() method, modifies CollectionCreateJob, CollectionModifyJob to send "VIRTUAL" flag in the requests, adds support for "VIRTUAL" flag in reponse to ProtocolHelper.
> 
> 
> Diffs
> -----
> 
>   akonadi/cachepolicypage.cpp b0650d5 
>   akonadi/collection.h ad5a267 
>   akonadi/collection.cpp f3d69ff 
>   akonadi/collection_p.h 0d94633 
>   akonadi/collectioncreatejob.cpp bed05d5 
>   akonadi/collectiondialog_desktop.cpp fb13e3e 
>   akonadi/collectionmodifyjob.cpp a54c5b9 
>   akonadi/collectionutils_p.h bd3b411 
>   akonadi/dragdropmanager.cpp 4542449 
>   akonadi/protocolhelper.cpp f1bca4f 
>   akonadi/standardactionmanager.cpp 4ebb5da 
>   akonadi/subscriptionmodel.cpp 68df7a6 
> 
> Diff: http://git.reviewboard.kde.org/r/106547/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/