[Kde-pim] Review Request: Fix body loss on copy/move from offline resource and improve error reporting (PART 1/2)

[Andras Mantia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106627/
-----------------------------------------------------------

Review request for Akonadi, KDEPIM-Libraries, Volker Krause, and David Faure.


Description
-------

The patch fixes the problem of losing the message body in certain operations when the resource is in offline mode (e.g copy from a not-fully-cached offline resource into an online one).
The second part of the patch is about getting correctly the error message from the resource, that will indicate the real problem (offline mode), instead of showing a generic "cannot fetch item" like message.


Diffs
-----

  interfaces/org.freedesktop.Akonadi.Resource.xml a716a1f 
  server/src/handler/colcopy.cpp 417df4c 
  server/src/handler/colmove.cpp 65b8b2f 
  server/src/handler/copy.cpp b67e4d3 
  server/src/handler/move.cpp 37fc8d6 
  server/src/storage/itemretrievaljob.h baafbf0 
  server/src/storage/itemretrievaljob.cpp c6f1ac6 
  server/src/storage/itemretriever.h 9744a37 
  server/src/storage/itemretriever.cpp c543ad2 

Diff: http://git.reviewboard.kde.org/r/106627/diff/


Testing
-------

Created with the help of David Faure and tested together.


Thanks,

Andras Mantia

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/