[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for kpimtextedit

Kevin Krammer krammer at kde.org
Sat Sep 8 17:52:26 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106307/#review18698
-----------------------------------------------------------



kpimtextedit/inserthtmldialog.cpp
<http://git.reviewboard.kde.org/r/106307/#comment14785>

    No, can't change a license header like this.
    revert this change and generate a separate review request for Laurent and check if any other committers are shown in git log



kpimtextedit/insertimagedialog.cpp
<http://git.reviewboard.kde.org/r/106307/#comment14786>

    same here



kpimtextedit/inserttabledialog.cpp
<http://git.reviewboard.kde.org/r/106307/#comment14787>

    same here



kpimtextedit/tableactionmenu.cpp
<http://git.reviewboard.kde.org/r/106307/#comment14788>

    same here



kpimtextedit/tableformatdialog.cpp
<http://git.reviewboard.kde.org/r/106307/#comment14789>

    same here


- Kevin Krammer


On Sept. 8, 2012, 4:28 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106307/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2012, 4:28 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Description
> -------
> 
> same as kdepimlibs/akonadi
> 
> 
> Diffs
> -----
> 
>   kpimtextedit/emailquotehighlighter.cpp 0103d34 
>   kpimtextedit/emoticontexteditaction.cpp 842b832 
>   kpimtextedit/emoticontexteditselector.h 0ee4004 
>   kpimtextedit/emoticontexteditselector.cpp 881523f 
>   kpimtextedit/inserthtmldialog.cpp 9cffb84 
>   kpimtextedit/insertimagedialog.cpp 44a9fcb 
>   kpimtextedit/inserttabledialog.cpp a0f0df1 
>   kpimtextedit/richtextbuilders/bbcodebuilder.cpp 05090dc 
>   kpimtextedit/richtextbuilders/kabstractmarkupbuilder.h 95d2c4f 
>   kpimtextedit/richtextbuilders/kmarkupdirector.cpp 6cb96dd 
>   kpimtextedit/richtextbuilders/kmarkupdirector_p.h 659b82b 
>   kpimtextedit/richtextbuilders/kmarkupdirector_p.cpp 0534547 
>   kpimtextedit/richtextbuilders/kplaintextmarkupbuilder.h 5962993 
>   kpimtextedit/richtextbuilders/kplaintextmarkupbuilder.cpp a23a657 
>   kpimtextedit/richtextbuilders/ktexthtmlbuilder.h 296416a 
>   kpimtextedit/richtextbuilders/ktexthtmlbuilder.cpp 5363195 
>   kpimtextedit/richtextbuilders/mediawikimarkupbuilder.h ba04c19 
>   kpimtextedit/richtextbuilders/mediawikimarkupbuilder.cpp 1eadfb7 
>   kpimtextedit/richtextbuilders/testapp/krichtexteditor.cpp e726c21 
>   kpimtextedit/richtextbuilders/testapp/main.cpp df4ac50 
>   kpimtextedit/richtextbuilders/tests/htmlbuildertest.cpp ec70227 
>   kpimtextedit/richtextbuilders/tests/plainmarkupbuildertest.cpp f7474c9 
>   kpimtextedit/tableactionmenu.cpp 7ad602a 
>   kpimtextedit/tableformatdialog.cpp b12ac14 
>   kpimtextedit/tests/textedittest.cpp dfa8c2f 
>   kpimtextedit/textedit.cpp b069db5 
>   kpimtextedit/textutils.cpp f436135 
> 
> Diff: http://git.reviewboard.kde.org/r/106307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list