[Kde-pim] Review Request: Merge akonadi-social-utils into kdepimlibs

[Martin Klapetek]

> On Sept. 30, 2012, 9:34 a.m., Volker Krause wrote:
> > akonadi/socialutils/imageprovider.h, line 66
> > <http://git.reviewboard.kde.org/r/106631/diff/2/?file=87708#file87708line66>
> >
> >     Consider moving private slots into the private class and using Q_PRIVATE_SLOT instead.

I was looking into that before and it cannot move these (at least not easily), because the recv(...) slot is connected from a KJob, that is created "on the fly" inside the loadImage(...) function and since the Q_PRIVATE_SLOT needs to be connected from inside the private class (correct?), I have no way of connecting this one. 

The second one - result(..) - emits a signal, so it can't be in the private object which is not a QObject.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106631/#review19632
-----------------------------------------------------------


On Sept. 29, 2012, 11:05 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106631/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2012, 11:05 a.m.)
> 
> 
> Review request for KDEPIM and KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> This is a final review request for merging the Akonadi Social Utils library into kdepimlibs.
> 
> Should the git history (not much in there..) be preserved as well? And if so, how should that be done? I've no experience with that :)
> 
> 
> Diffs
> -----
> 
>   akonadi/CMakeLists.txt 8778c9c 
>   akonadi/socialutils/.krazy PRE-CREATION 
>   akonadi/socialutils/CMakeLists.txt PRE-CREATION 
>   akonadi/socialutils/Mainpage.dox PRE-CREATION 
>   akonadi/socialutils/imageprovider.h PRE-CREATION 
>   akonadi/socialutils/imageprovider.cpp PRE-CREATION 
>   akonadi/socialutils/libakonadisocialutils_export.h PRE-CREATION 
>   akonadi/socialutils/serializer/CMakeLists.txt PRE-CREATION 
>   akonadi/socialutils/serializer/README PRE-CREATION 
>   akonadi/socialutils/serializer/akonadi-serializer.png PRE-CREATION 
>   akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.cpp PRE-CREATION 
>   akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.desktop PRE-CREATION 
>   akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.h PRE-CREATION 
>   akonadi/socialutils/serializer/x-vnd.akonadi.socialfeeditem.xml PRE-CREATION 
>   akonadi/socialutils/socialfeeditem.h PRE-CREATION 
>   akonadi/socialutils/socialfeeditem.cpp PRE-CREATION 
>   akonadi/socialutils/socialnetworkattributes.h PRE-CREATION 
>   akonadi/socialutils/socialnetworkattributes.cpp PRE-CREATION 
>   akonadi/socialutils/tests/CMakeLists.txt PRE-CREATION 
>   akonadi/socialutils/tests/image-provider-tests.h PRE-CREATION 
>   akonadi/socialutils/tests/image-provider-tests.cpp PRE-CREATION 
>   cmake/modules/FindQJSON.cmake PRE-CREATION 
>   cmake/modules/FindQtOAuth.cmake PRE-CREATION 
>   includes/Akonadi/SocialUtils/ImageProvider PRE-CREATION 
>   includes/Akonadi/SocialUtils/SocialFeedItem PRE-CREATION 
>   includes/Akonadi/SocialUtils/SocialNetworkAttributes PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106631/diff/
> 
> 
> Testing
> -------
> 
> Everything builds.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/