[Kde-pim] Review Request: Update Item's remoteRevision in Akonadi::Item::apply()

Kevin Krammer krammer at kde.org
Wed Oct 3 16:41:35 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106710/#review19835
-----------------------------------------------------------



akonadi/item.cpp
<http://git.reviewboard.kde.org/r/106710/#comment15757>

    might even make sense to move this to right after setRevision or setRemoteId


- Kevin Krammer


On Oct. 3, 2012, 12:05 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106710/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 12:05 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Volker Krause.
> 
> 
> Description
> -------
> 
> Akonadi::Item::apply() does not update item's remote revision (but updates remote Id twice :P ). This causes a bug in KOrganizer that prevents editing a single event twice in one KOrganizer session.
> 
> 
> This addresses bug 283954.
>     http://bugs.kde.org/show_bug.cgi?id=283954
> 
> 
> Diffs
> -----
> 
>   akonadi/item.cpp 0cb4b3d 
> 
> Diff: http://git.reviewboard.kde.org/r/106710/diff/
> 
> 
> Testing
> -------
> 
> Fixes bug #283954, does not seem to break anything else.
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list