[Kde-pim] Review Request: Disable contact searching in message viewer

[Andras Mantia]

> On Oct. 23, 2012, 8:59 p.m., Thomas McGuire wrote:
> > Thanks, this will make it much better for most users.
> > 
> > I am wondering about the usecase in the messageviewer though: This is using the memento pattern, which is supposed to be fully async - the message should first be displayed without photo, and once the photo is fetched, update and show the photo. Any idea why that is not working?

You are right, it should not stop, but it does. To be honest, didn't try to debug it too much. The memento creation returns as it should, but still the content is not rendered until the job is finished.


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107003/#review20764
-----------------------------------------------------------


On Oct. 23, 2012, 7:42 a.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107003/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 7:42 a.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> One of the slowest things nowadays in Kontact/KMail is searching for contacts using Nepomuk via ContactSearchJob. Until this is fixed, I propose the following patch, that disables lookup for contact photos (to be displayed in Fancy Headers) and searching for contacts when right clicking in a mail. The second thing is somewhat optimized, to search only if you clicked on a mailto link, and not in other cases, but as that would be still slow, i added the #if 0 also around that.
> Note: same code is in KMReaderMainWin, not fixed yet, just commented with TODO as the real fix is merging the code.
> 
> This is not a real fix, is more like making KMail repsonsive *now*.
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.h bc9a76c 
>   kmail/kmmainwidget.cpp d7d1660 
>   kmail/kmreadermainwin.cpp 54ff7c5 
>   messageviewer/headerstyle.cpp 26c0182 
> 
> Diff: http://git.reviewboard.kde.org/r/107003/diff/
> 
> 
> Testing
> -------
> 
> Test results: no more Retrieving Folder Contents message shown for 10+ seconds and no 10+ second delay when right clicking in a mail.
> 
> 
> Thanks,
> 
> Andras Mantia
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/