[Kde-pim] Review Request: Sync to async for some nepomuk calls
Christian Mollekopf
chrigi_1 at fastmail.fm
Sat Oct 13 13:54:20 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106822/#review20258
-----------------------------------------------------------
Ship it!
Looks ok to me.
- Christian Mollekopf
On Oct. 13, 2012, 10:39 a.m., Andras Mantia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106822/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2012, 10:39 a.m.)
>
>
> Review request for KDEPIM and Christian Mollekopf.
>
>
> Description
> -------
>
> Change Nepomuk tag querying from sync to async calls. Still doesn't fix all failures on startup, as even with this a call to tag.label() is synchornous and can block.
>
>
> Diffs
> -----
>
> kmail/tagactionmanager.h 85495f6
> kmail/tagactionmanager.cpp 57ae394
> libkdepim/addresseelineedit.cpp 644be96
> mailcommon/filter/filteractionaddtag.h 48a6c26
> mailcommon/filter/filteractionaddtag.cpp eb65c9f
>
> Diff: http://git.reviewboard.kde.org/r/106822/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andras Mantia
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list