[Kde-pim] Review Request: Prevent KOrganizer from ignoring reminders that trigger during downtime

[Frank Roscher]

> On Oct. 26, 2012, 12:53 p.m., Allen Winter wrote:
> > Should go into the KDE/4.9 branch as well.
> 
> David Jarvie wrote:
>     Looks good to me as well.
> 
> Allen Winter wrote:
>     Frank, do you have a commit account?  If not, I can commit for you.
>     Let me know.
> 
> Frank Roscher wrote:
>     Thank you; I do have an account, regrettably underused as it may be. Before I commit, though, I'm afraid I need to know how to handle the fact that this patch depends on David's patches - which at the moment are only in master, not in 4.9.
>     David, could you maybe backport your commits 0efc457d2158dc4182128452059f632d75778490 and f0e7df76c21834f7a3efb7a7f35152a4ae16393d?
>     
>     Also, I can't seem to find a clear recommendation anywhere on how to commit bug fixes in the git era; am I right in assuming I should commit to the branch and then merge the branch to master? That seems to be what other people are doing in kdepim.
> 
> David Jarvie wrote:
>     My patches can't be backported, because they would introduce new features to the 4.9 branch.

Okay, so I went ahead and committed it to master only.
Thank you, everybody, for the help!


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106824/#review20951
-----------------------------------------------------------


On Oct. 24, 2012, 6:35 p.m., Frank Roscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106824/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 6:35 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Since the switch to Akonadi, KOrganizer has had a pretty serious bug: If the collection and its items haven't already been loaded at the time of startup, the first check for reminders is performed against an empty collection. When the collection does show up, korgac thinks it has already checked for a backlog of reminders and thus only displays reminders that were supposed to trigger during the last minute or so. The result is that all reminders that are supposed to trigger while korgac is not running are silently ignored. This is especially harsh for birthday reminders, which usually get triggered at midnight.
> 
> This small patch tries to fix that using the new collectionTreeFetched/isCollectionTreeFetched functionality in EntityTreeModel, introduced by David Jarvie.
> 
> 
> This addresses bug 282535.
>     http://bugs.kde.org/show_bug.cgi?id=282535
> 
> 
> Diffs
> -----
> 
>   korganizer/korgac/koalarmclient.h adc8cef 
>   korganizer/korgac/koalarmclient.cpp 34e9a42 
> 
> Diff: http://git.reviewboard.kde.org/r/106824/diff/
> 
> 
> Testing
> -------
> 
> I tested the triggering of reminders at startup in Xephyr sessions using a new user account. Reminders in two separate collections instead of only one were tested. All collections were local, though.
> Disclaimer: I have a very limited knowledge about the Akonadi internals and might be fundamentally misunderstanding something about all this. Still, in my tests it has worked flawlessly.
> 
> 
> Thanks,
> 
> Frank Roscher
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/