[Kde-pim] Review Request: Prevent KOrganizer from ignoring reminders that trigger during downtime

[Frank Sebastian Roscher]

> On Oct. 18, 2012, 12:03 a.m., Sergio Luis Martins wrote:
> > Not sure. Shouldn't we wait for all items then, instead of just waiting for collections ?
> 
> David Jarvie wrote:
>     Yes, you need to wait first for the collection tree to be populated, and then for the items in the collections to be fetched. KAlarm also needs to do this - see CollectionControlModel::waitUntilPopulated() in kdepim/kalarm/collectionmodel.cpp.
> 
> Frank Sebastian Roscher wrote:
>     Thank you for the pointers, I'll try to understand the kalarm code. I am a little confused, though; in my tests, the collectionPopulated signals consistently arrived _before_ collectionTreeFetched. I assumed this was caused by the itemFetchScope or something like that and that it meant I wouldn't need to implement more intricate checks.
>     
>     By the way, could it be that there was intended to be an isPopulated method in ETM? It's referenced in the comment for collectionPopulated, but it's not defined anywhere.
> 
> David Jarvie wrote:
>     I'd be surprised if all collectionPopulated signals could arrive before collectionTreeFetched - the model can't know which collection to fetch items for until it has identified the collections. Certainly when I was developing the KAlarm code, I found that the collectionTreeFetched signal arrived first.
>     
>     As for the isPopulated() method, that's a documentation mistake which I'll remove - it's a hangover from the original patch from which isPopulated() was later removed.

Okay, so that indicates something funny going on then. I'll email you the details privately as that doesn't really belong in here.


- Frank Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106824/#review20529
-----------------------------------------------------------


On Oct. 13, 2012, 3:04 p.m., Frank Sebastian Roscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106824/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2012, 3:04 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Since the switch to Akonadi, KOrganizer has had a pretty serious bug: If the collection and its items haven't already been loaded at the time of startup, the first check for reminders is performed against an empty collection. When the collection does show up, korgac thinks it has already checked for a backlog of reminders and thus only displays reminders that were supposed to trigger during the last minute or so. The result is that all reminders that are supposed to trigger while korgac is not running are silently ignored. This is especially harsh for birthday reminders, which usually get triggered at midnight.
> 
> This small patch tries to fix that using the new collectionTreeFetched/isCollectionTreeFetched functionality in EntityTreeModel, introduced by David Jarvie.
> 
> 
> This addresses bug 282535.
>     http://bugs.kde.org/show_bug.cgi?id=282535
> 
> 
> Diffs
> -----
> 
>   korganizer/korgac/koalarmclient.h adc8cef 
>   korganizer/korgac/koalarmclient.cpp 34e9a42 
> 
> Diff: http://git.reviewboard.kde.org/r/106824/diff/
> 
> 
> Testing
> -------
> 
> I tested the triggering of reminders at startup in Xephyr sessions using a new user account. Reminders in two separate collections instead of only one were tested. All collections were local, though.
> Disclaimer: I have a very limited knowledge about the Akonadi internals and might be fundamentally misunderstanding something about all this. Still, in my tests it has worked flawlessly.
> 
> 
> Thanks,
> 
> Frank Sebastian Roscher
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/