[Kde-pim] Review Request: Make E-Mail successfully sent / E-Mail sending failed messages prettier

Kai Uwe Broulik kde at privat.broulik.de
Thu Oct 4 15:33:38 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106725/
-----------------------------------------------------------

Review request for KDEPIM.


Description
-------

This fixes the E-Mail Successfully Sent (and failed) messages using a hardcoded size pixmap by moving the icon logic to the notifyrc. Also adds a title string that sumarizes the messages. I used "mail-mark-junk" for mail sending failed because I didn’t want to use a generic dialog-error and we don’t have an apporpriate error icon for mails. I think it fits.


Diffs
-----

  agents/maildispatcher/akonadi_maildispatcher_agent.notifyrc b3846c7 
  agents/maildispatcher/maildispatcheragent.cpp 04543ab 

Diff: http://git.reviewboard.kde.org/r/106725/diff/


Testing
-------

Tested it on 4.9 (on my project neon akonadi doesnt work) and sent a mail. New pretty messages appeared (see screenshot).


Screenshots
-----------

Prettier notification
  http://git.reviewboard.kde.org/r/106725/s/754/
Prettier error notification
  http://git.reviewboard.kde.org/r/106725/s/755/


Thanks,

Kai Uwe Broulik

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list