[Kde-pim] Review Request: Disable contact searching in message viewer

[Andras Mantia]

> On Oct. 23, 2012, 8:13 a.m., Kevin Krammer wrote:
> > kmail/kmmainwidget.h, line 515
> > <http://git.reviewboard.kde.org/r/107003/diff/1/?file=92040#file92040line515>
> >
> >     just a matter of style, but I am missing some whitespaces around &. e.g. const Akonadi::Item&msg should probably be const Akonadi::Item &msg

Sure, I just copy pasted this from some lines above. ;)


> On Oct. 23, 2012, 8:13 a.m., Kevin Krammer wrote:
> > kmail/kmmainwidget.cpp, line 2937
> > <http://git.reviewboard.kde.org/r/107003/diff/1/?file=92041#file92041line2937>
> >
> >     where does that condition come from?
> >

This code is invoked when you right click inside the mail. Previously a contact search was run, independently where you clicked. Now it is run (once the #if is enabled) only when you click on a mailto link (in the message viewer the message content is rendered in html, including the headers, and addresses are using a mailto link).


> On Oct. 23, 2012, 8:13 a.m., Kevin Krammer wrote:
> > kmail/kmmainwidget.cpp, line 2936
> > <http://git.reviewboard.kde.org/r/107003/diff/1/?file=92041#file92041line2936>
> >
> >     maybe use a define with a name?
> >     easer to grep for when looking for affected locations when it will be re-enabled again

Makes sense.


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107003/#review20720
-----------------------------------------------------------


On Oct. 23, 2012, 7:42 a.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107003/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 7:42 a.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> One of the slowest things nowadays in Kontact/KMail is searching for contacts using Nepomuk via ContactSearchJob. Until this is fixed, I propose the following patch, that disables lookup for contact photos (to be displayed in Fancy Headers) and searching for contacts when right clicking in a mail. The second thing is somewhat optimized, to search only if you clicked on a mailto link, and not in other cases, but as that would be still slow, i added the #if 0 also around that.
> Note: same code is in KMReaderMainWin, not fixed yet, just commented with TODO as the real fix is merging the code.
> 
> This is not a real fix, is more like making KMail repsonsive *now*.
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.h bc9a76c 
>   kmail/kmmainwidget.cpp d7d1660 
>   kmail/kmreadermainwin.cpp 54ff7c5 
>   messageviewer/headerstyle.cpp 26c0182 
> 
> Diff: http://git.reviewboard.kde.org/r/107003/diff/
> 
> 
> Testing
> -------
> 
> Test results: no more Retrieving Folder Contents message shown for 10+ seconds and no 10+ second delay when right clicking in a mail.
> 
> 
> Thanks,
> 
> Andras Mantia
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/