[Kde-pim] Review Request: Optimize ChangeRecorder to only update 8 bytes on disk when dequeuing.

[Andras Mantia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106950/#review20614
-----------------------------------------------------------

Ship it!


Although I had some problems replaying the changerecorder log for the feeder (log that was piling up since ages), we couldn't prove the problem is with the patch and since that log is gone, I saw not problems

- Andras Mantia


On Oct. 19, 2012, 1:33 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106950/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 1:33 p.m.)
> 
> 
> Review request for Akonadi, Volker Krause and Andras Mantia.
> 
> 
> Description
> -------
> 
> Optimize ChangeRecorder to only update 8 bytes on disk when dequeuing.
> 
> Rather than saving the whole file (of pending notifications) every
> time, just because the first item was dequeued. This reduces disk I/O
> considerably, and speeds up processing (especially in the nepomuk
> feeder). In the IMAP resource (when marking 2000 emails as read) I
> couldn't time a difference since it's mostly network-based anyway.
> But at least the disk is usable by other processes meanwhile ;)
> 
> 
> This addresses bug 300572.
>     http://bugs.kde.org/show_bug.cgi?id=300572
> 
> 
> Diffs
> -----
> 
>   akonadi/changerecorder.cpp c3d3640679a9a679449fa6f0ce1a34a9d79cf351 
>   akonadi/changerecorder_p.h 1100579aaa6beb53725bb5fc96e2e5c356cbab54 
>   akonadi/changerecorder_p.cpp 6582ba4e8391bf77686e4feabf06b4bdf6c1bfc3 
> 
> Diff: http://git.reviewboard.kde.org/r/106950/diff/
> 
> 
> Testing
> -------
> 
> changerecorder and monitornotification unit tests [is there any other that might apply?]
> Applying the patch and restarting akonadi (existing files get converted to new format).
> Running with the patch for a few days.
> Marking 2000 emails as read.
> Watching nepomukfeeder process all pending notifications.
> 
> 
> Thanks,
> 
> David Faure
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/