[Kde-pim] Review Request: Don't always recompress contact photos when saving

[Kevin Krammer]

> On Oct. 13, 2012, 8:38 a.m., Kevin Krammer wrote:
> > kabc/vcardtool.cpp, line 805
> > <http://git.reviewboard.kde.org/r/106745/diff/3/?file=88609#file88609line805>
> >
> >     I think you'll also need to save the type, otherwise pic will have rawData but no type and saving that would save rawData and empty type information.
> >     
> >     Make sure you have a roundtrip unittest for that
> 
> Sebastian Scheibner wrote:
>     the type is set a few lines below in line 814.
>     I'll try to add a new test file vcardtooltest.cpp to test the parsePicture and createPicture function.
> 
> Kevin Krammer wrote:
>     Right, didn't see that, sorry. disregard the issue but add a test just to ensure this in the future
> 
> Sebastian Scheibner wrote:
>     not sure how to make a test for that, as it's a private method.
>

You'll have to go through the public API. If the vcard is otherwise minimial, the test will be for parsePicture and createPicture


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106745/#review20247
-----------------------------------------------------------


On Oct. 21, 2012, 9:39 p.m., Sebastian Scheibner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106745/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2012, 9:39 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> When changing a contact with a photo, the photo is recompressed when saving (even though the photo wasn't changed). That's because the photo is loaded into a QImage and when the contact is saved, the QImage is compressed as JPEG again (or PNG if it contains an alpha-channel, which most don't).
> 
> This patch stores the raw base64 photo data from the vcard as a QByteArray in KABC::Picture. If the photo is not changed, this QByteArray is simply used when saving the contact, so there's no recompression and quality loss. If the photo was changed it gets compressed as JPEG as before.
> 
> fixes this bug: https://bugs.kde.org/show_bug.cgi?id=307570
> 
> 
> This addresses bug 307570.
>     http://bugs.kde.org/show_bug.cgi?id=307570
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/editor/imagewidget.h 92df283 
>   akonadi/contact/editor/imagewidget.cpp e1a0527 
>   kabc/picture.h bf9745c 
>   kabc/picture.cpp 0a51c8b 
>   kabc/tests/picturetest.h 2b33e18 
>   kabc/tests/picturetest.cpp b599b48 
>   kabc/vcardtool.cpp e876e81 
> 
> Diff: http://git.reviewboard.kde.org/r/106745/diff/
> 
> 
> Testing
> -------
> 
> compiled kdepimlibs/kabc with kde 4.9.2
> 
> - created a new contact in kaddressbook and added a photo. exported the contact.
> - changed the photo and exported the contact again
> - the image data in the exported file didn't change
> 
> 
> Thanks,
> 
> Sebastian Scheibner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/