[Kde-pim] Review Request: some more spaces, some less spaces, some more blocks, for syndication, part 1

Kevin Krammer krammer at kde.org
Sat Oct 13 16:55:59 BST 2012 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106418/#review20251
-----------------------------------------------------------



syndication/dataretriever.h
<http://git.reviewboard.kde.org/r/106418/#comment16025>

    trailing space



syndication/dataretriever.h
<http://git.reviewboard.kde.org/r/106418/#comment16026>

    same here



syndication/dataretriever.h
<http://git.reviewboard.kde.org/r/106418/#comment16027>

    same here



syndication/mapper/feedatomimpl.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16008>

    spaces in PersonImpl()



syndication/mapper/itematomimpl.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16009>

    spaces in PersonImpl()



syndication/mapper/itematomimpl.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16010>

    spaces in PersonImpl()



syndication/mapper/itemrdfimpl.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16011>

    spaces in Property()



syndication/mapper/mapperatomimpl.h
<http://git.reviewboard.kde.org/r/106418/#comment16012>

    spaces in FeedAtomImpl()



syndication/mapper/mapperrss2impl.h
<http://git.reviewboard.kde.org/r/106418/#comment16013>

    spaces in FeedRSS2Impl()



syndication/parsercollectionimpl.h
<http://git.reviewboard.kde.org/r/106418/#comment15993>

    space between itm and )



syndication/parsercollectionimpl.h
<http://git.reviewboard.kde.org/r/106418/#comment15994>

    spaces in contains()



syndication/parsercollectionimpl.h
<http://git.reviewboard.kde.org/r/106418/#comment15995>

    spaces in accept()



syndication/parsercollectionimpl.h
<http://git.reviewboard.kde.org/r/106418/#comment15996>

    spaces in map()



syndication/parsercollectionimpl.h
<http://git.reviewboard.kde.org/r/106418/#comment15997>

    spaces in source()



syndication/rdf/document.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16014>

    const Item &i



syndication/rdf/document.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16015>

    const SortItem &sortItem



syndication/rdf/document.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16016>

    const ResourcePtr &i



syndication/rdf/document.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16017>

    const NodePtr &i



syndication/rdf/literal.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16018>

    const Literal *o2



syndication/rdf/model.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16019>

    spaces in contains()



syndication/rdf/modelmaker.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16020>

    spaces in attribute()



syndication/rdf/modelmaker.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16021>

    spaces in attribute()



syndication/rdf/resource.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16022>

    const Resource *o2



syndication/rdf/resource.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16023>

    spaces in visitResource()



syndication/rdf/statement.cpp
<http://git.reviewboard.kde.org/r/106418/#comment16024>

    spaces in ResourcePtr()


- Kevin Krammer


On Sept. 10, 2012, 11:38 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106418/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2012, 11:38 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Description
> -------
> 
> same as kdepimlibs/akonadi
> 
> 
> Diffs
> -----
> 
>   syndication/atom/atomtools.h 5ce2c38 
>   syndication/atom/atomtools.cpp 46c1d0e 
>   syndication/atom/category.cpp f27f527 
>   syndication/atom/constants.cpp 3e35523 
>   syndication/atom/content.h 7617845 
>   syndication/atom/content.cpp bd9e5d9 
>   syndication/atom/document.h 336563c 
>   syndication/atom/document.cpp da0838b 
>   syndication/atom/entry.h 76d3cbe 
>   syndication/atom/entry.cpp c8c9643 
>   syndication/atom/generator.cpp 59f5ec0 
>   syndication/atom/link.cpp 76303bd 
>   syndication/atom/parser.cpp 2338f81 
>   syndication/atom/person.cpp c5bb37b 
>   syndication/atom/source.cpp 26f7245 
>   syndication/category.cpp 7a63b58 
>   syndication/constants.cpp 5557d69 
>   syndication/dataretriever.h a9cfd88 
>   syndication/dataretriever.cpp fcecec6 
>   syndication/documentsource.cpp d608164 
>   syndication/documentvisitor.cpp e892e1a 
>   syndication/elementwrapper.cpp 85373df 
>   syndication/enclosure.cpp 0e2b058 
>   syndication/feed.cpp 97ffd65 
>   syndication/global.h 5ea4cf8 
>   syndication/global.cpp 8d162d5 
>   syndication/image.cpp 117d5bf 
>   syndication/item.cpp 5b4d5e2 
>   syndication/loader.cpp 7141c9b 
>   syndication/mapper/categoryatomimpl.h 11d9c35 
>   syndication/mapper/categoryrss2impl.h 2d4a917 
>   syndication/mapper/categoryrss2impl.cpp 2660798 
>   syndication/mapper/enclosureatomimpl.h f1fb756 
>   syndication/mapper/enclosureatomimpl.cpp 6110d2f 
>   syndication/mapper/enclosurerss2impl.h 1960314 
>   syndication/mapper/enclosurerss2impl.cpp 8341703 
>   syndication/mapper/feedatomimpl.h 058a49a 
>   syndication/mapper/feedatomimpl.cpp 93f786b 
>   syndication/mapper/feedrdfimpl.h 673a3f5 
>   syndication/mapper/feedrdfimpl.cpp 166d3a5 
>   syndication/mapper/feedrss2impl.h 49b6781 
>   syndication/mapper/feedrss2impl.cpp 5207503 
>   syndication/mapper/imageatomimpl.h cd6378b 
>   syndication/mapper/imagerdfimpl.h 636799f 
>   syndication/mapper/imagerdfimpl.cpp 89c43c1 
>   syndication/mapper/imagerss2impl.h 433446e 
>   syndication/mapper/imagerss2impl.cpp a8c4f85 
>   syndication/mapper/itematomimpl.h d212c5c 
>   syndication/mapper/itematomimpl.cpp 254ef65 
>   syndication/mapper/itemrdfimpl.h b0af045 
>   syndication/mapper/itemrdfimpl.cpp e8838d3 
>   syndication/mapper/itemrss2impl.h 0be3570 
>   syndication/mapper/itemrss2impl.cpp ba5ed5e 
>   syndication/mapper/mapperatomimpl.h b5b1e5a 
>   syndication/mapper/mapperrss2impl.h 1d8790b 
>   syndication/parsercollectionimpl.h ad2b20c 
>   syndication/person.cpp c260146 
>   syndication/personimpl.h e444762 
>   syndication/personimpl.cpp bcd093e 
>   syndication/rdf/contentvocab.h f6646c3 
>   syndication/rdf/contentvocab.cpp ff972ad 
>   syndication/rdf/document.h 232837d 
>   syndication/rdf/document.cpp 997e3c9 
>   syndication/rdf/literal.cpp 3ea42b1 
>   syndication/rdf/model.cpp 30483f6 
>   syndication/rdf/model_p.h cee7d43 
>   syndication/rdf/modelmaker.h 4abfcd5 
>   syndication/rdf/modelmaker.cpp daf0546 
>   syndication/rdf/nodevisitor.cpp bec6462 
>   syndication/rdf/parser.cpp f675236 
>   syndication/rdf/property.h b631db6 
>   syndication/rdf/property.cpp 57e7625 
>   syndication/rdf/rdfvocab.h 7ba4161 
>   syndication/rdf/rdfvocab.cpp 11964b2 
>   syndication/rdf/resource.cpp 6bbb209 
>   syndication/rdf/resourcewrapper.h 9072826 
>   syndication/rdf/resourcewrapper.cpp 452925b 
>   syndication/rdf/rssvocab.h 2aef607 
>   syndication/rdf/rssvocab.cpp 786fcb9 
>   syndication/rdf/sequence.h 04b7cb9 
>   syndication/rdf/sequence.cpp a981993 
>   syndication/rdf/statement.h cb5e148 
>   syndication/rdf/statement.cpp b9e412a 
> 
> Diff: http://git.reviewboard.kde.org/r/106418/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list